feat: GSTIN Status report #3011

karm1000 · 2025-01-30T10:07:28Z

huly-for-github · 2025-01-30T10:07:38Z

codecov · 2025-01-30T10:17:00Z

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 56.97%. Comparing base (a3354d4) to head (301d2d1).
Report is 8 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ance/gst_india/report/gstin_status/gstin_status.py	0.00%	31 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3011      +/-   ##
===========================================
- Coverage    57.28%   56.97%   -0.32%     
===========================================
  Files          126      127       +1     
  Lines        12705    12785      +80     
===========================================
+ Hits          7278     7284       +6     
- Misses        5427     5501      +74

Files with missing lines	Coverage Δ
...ance/gst_india/report/gstin_status/gstin_status.py	`0.00% <0.00%> (ø)`

... and 5 files with indirect coverage changes

…gstin

…and response is successful

…is_blocked value of gstin document from backend

…hance ui for updating gstin info;

… of cell

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js

…ke formatting the value more dynamic;

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.json

…tton text logic

vorasmit

Just 2 things for this to be merged.

Report name need not have report keyword
Add this to GST dashboard

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js

Co-authored-by: ljain112 <ljain112@gmail.com> (cherry picked from commit c61c96b) # Conflicts: # india_compliance/gst_india/workspace/gst_india/gst_india.json

…tfix/pr-3011 feat: GSTIN Status report (backport #3011)

# [15.16.0](v15.15.0...v15.16.0) (2025-02-04) ### Bug Fixes * add more fields ([1d51694](1d51694)) * added bill_date column and mapping for linked voucher ([3fb980c](3fb980c)) * added posting date column for export ([894eab4](894eab4)) * changes not available in version-15 ([5b630ee](5b630ee)) * convert ewaybill number to string for IRN retrieval; hence support its indexing ([91384b5](91384b5)) * correct string formatting in version compatibility error message ([53abd5c](53abd5c)) * css for actions summary ([64e1e9a](64e1e9a)) * delete transactions marked as rejected ([07180f8](07180f8)) * don't set default IMS action ([dd557d8](dd557d8)) * format bill_date and bill_no ([31f12ba](31f12ba)) * Improved Data Flow in Purchase Reconciliation Tool ([#2953](#2953)) ([613931d](613931d)) * load set_gstin_options in public.js so that it's accessible in 3b report ([0c61718](0c61718)) * make e-waybill-detailed print format ([2314e71](2314e71)) * more reliable way to link integration request ([db9866f](db9866f)) * new versions for black, isort, flake8 ([119e0cf](119e0cf)) * remove filters correctly from ui too ([9b38da4](9b38da4)) * remove unnecessary padding ([58399cf](58399cf)) * reverse_charge filter for purchase reconciliation tool ([d171f51](d171f51)) * set irn from data json removed ([2fb0ed9](2fb0ed9)) * set year as per doc ([6681ef1](6681ef1)) * Suggest Invoices that Should be Marked as Pending ([#3009](#3009)) ([0e7377f](0e7377f)) * throw when no request data found ([b749376](b749376)) * update address mapping; variable names; conditional IRN being set ([cc61926](cc61926)) * update fieldnames ([7ad6dda](7ad6dda)) * update UI of e-Waybill print-format ([ace8313](ace8313)) ### Features * export document view for IMS ([672ee7f](672ee7f)) * GST Invoice Management System (IMS) Implementation ([#2638](#2638)) ([5b1c084](5b1c084)) * GST Invoice Management System (IMS) Implementation (backport [#2638](#2638)) ([#2994](#2994)) ([8729bf3](8729bf3)) * GSTIN Status report ([#3011](#3011)) ([5681351](5681351))

karm1000 added 2 commits January 29, 2025 19:04

feat: make gstin report

0fbdebd

fix: use query builder to get data in gstin report

033660e

karm1000 marked this pull request as draft January 30, 2025 10:08

karm1000 added 2 commits January 30, 2025 19:16

fix: add client-side script to gstin report, add update on click for …

21a466c

…gstin

fix: make consistent date format, disable update button when clicked …

4a1c8bb

…and response is successful

karm1000 marked this pull request as ready for review January 31, 2025 07:27

karm1000 and others added 4 commits January 31, 2025 13:56

fix: update gstin document when update button clicked, send readable …

24f0685

…is_blocked value of gstin document from backend

feat: convert fieldtype to Link for gstin, party_name, party_type; en…

cd0f046

…hance ui for updating gstin info;

refactor: changes as per review

58457c1

fix: update the logic of update button in report, to change the value…

8356569

… of cell

ljain112 reviewed Feb 3, 2025

View reviewed changes

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js Outdated Show resolved Hide resolved

ljain112 reviewed Feb 3, 2025

View reviewed changes

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js Outdated Show resolved Hide resolved

ljain112 reviewed Feb 3, 2025

View reviewed changes

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js Outdated Show resolved Hide resolved

ljain112 reviewed Feb 3, 2025

View reviewed changes

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js Outdated Show resolved Hide resolved

fix: add color in gstin status of the gstin report; refactor code; ma…

5b85eb8

…ke formatting the value more dynamic;

karm1000 force-pushed the gstin_report branch from db4a736 to 5b85eb8 Compare February 3, 2025 10:25

vorasmit reviewed Feb 3, 2025

View reviewed changes

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.json Outdated Show resolved Hide resolved

vorasmit and others added 5 commits February 3, 2025 17:38

fix: handle null values for is_blocked, js formatting, use party gstin

70bd0a6

fix: remove unused parameter from add_on_click_listener and update bu…

f9c2c81

…tton text logic

fix: column and row width, pretty date

d4f5a97

fix: change GSTIN report name

916c0a6

fix: don't format status if empty; better width for party name

c7b9697

vorasmit requested changes Feb 3, 2025

View reviewed changes

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js Outdated Show resolved Hide resolved

india_compliance/gst_india/report/gstin_detailed/gstin_detailed.js Outdated Show resolved Hide resolved

vorasmit added squash backport version-15-hotfix labels Feb 3, 2025

ljain112 added 2 commits February 3, 2025 19:31

fix: rename report

5ef7a81

fix: added report to dashboard

301d2d1

ljain112 requested a review from vorasmit February 3, 2025 14:04

vorasmit changed the title ~~feat: make GSTIN Detail report~~ feat: GSTIN Status report Feb 3, 2025

vorasmit merged commit c61c96b into resilient-tech:develop Feb 3, 2025
7 of 10 checks passed

mergify bot pushed a commit that referenced this pull request Feb 3, 2025

feat: GSTIN Status report (#3011)

5681351

Co-authored-by: ljain112 <ljain112@gmail.com> (cherry picked from commit c61c96b) # Conflicts: # india_compliance/gst_india/workspace/gst_india/gst_india.json

mergify bot mentioned this pull request Feb 3, 2025

feat: GSTIN Status report (backport #3011) #3022

Merged

mergify bot added a commit that referenced this pull request Feb 3, 2025

Merge pull request #3022 from resilient-tech/mergify/bp/version-15-ho…

65b6876

…tfix/pr-3011 feat: GSTIN Status report (backport #3011)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: GSTIN Status report #3011

feat: GSTIN Status report #3011

karm1000 commented Jan 30, 2025 •

edited by ljain112

Loading

huly-for-github bot commented Jan 30, 2025

codecov bot commented Jan 30, 2025 •

edited

Loading

vorasmit left a comment

feat: GSTIN Status report #3011

feat: GSTIN Status report #3011

Conversation

karm1000 commented Jan 30, 2025 • edited by ljain112 Loading

huly-for-github bot commented Jan 30, 2025

codecov bot commented Jan 30, 2025 • edited Loading

Codecov Report

vorasmit left a comment

Choose a reason for hiding this comment

karm1000 commented Jan 30, 2025 •

edited by ljain112

Loading

codecov bot commented Jan 30, 2025 •

edited

Loading