fix: validate original references on before_submit hook

(cherry picked from commit 2a6beab)
resilient-tech · Aug 29, 2024 · fada0e5 · fada0e5
1 parent a7c223b
commit fada0e5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 11 deletions.
diff --git a/india_compliance/gst_india/overrides/subcontracting_transaction.py b/india_compliance/gst_india/overrides/subcontracting_transaction.py
@@ -167,17 +167,6 @@ def validate(doc, method=None):
     if ignore_gst_validation_for_subcontracting(doc):
         return
 
-    if (doc.doctype == "Stock Entry" and doc.purpose == "Material Transfer") or (
-        doc.doctype == "Subcontracting Receipt" and not doc.is_return
-    ):
-        if not doc.doc_references:
-            frappe.throw(
-                _("Please Select Original Document Reference for ITC-04 Reporting"),
-                title=_("Mandatory Field"),
-            )
-        else:
-            remove_duplicates(doc)
-
     field_map = (
         STOCK_ENTRY_FIELD_MAP
         if doc.doctype == "Stock Entry"
@@ -194,6 +183,23 @@ def validate(doc, method=None):
     update_gst_details(doc)
 
 
+def before_submit(doc, method=None):
+    # Stock Entries with Subcontracting Order should only be considered
+    if ignore_gst_validation_for_subcontracting(doc):
+        return
+
+    if (doc.doctype == "Stock Entry" and doc.purpose == "Material Transfer") or (
+        doc.doctype == "Subcontracting Receipt" and not doc.is_return
+    ):
+        if not doc.doc_references:
+            frappe.throw(
+                _("Please Select Original Document Reference for ITC-04 Reporting"),
+                title=_("Mandatory Field"),
+            )
+        else:
+            remove_duplicates(doc)
+
+
 def validate_transaction(doc, method=None):
     if doc.doctype == "Stock Entry":
         company_gstin_field = "bill_from_gstin"

diff --git a/india_compliance/hooks.py b/india_compliance/hooks.py
@@ -234,6 +234,7 @@
     "Stock Entry": {
         "onload": "india_compliance.gst_india.overrides.subcontracting_transaction.onload",
         "validate": "india_compliance.gst_india.overrides.subcontracting_transaction.validate",
+        "before_submit": "india_compliance.gst_india.overrides.subcontracting_transaction.before_submit",
         "after_mapping": "india_compliance.gst_india.overrides.subcontracting_transaction.after_mapping_stock_entry",
     },
     "Subcontracting Order": {
@@ -243,6 +244,7 @@
     "Subcontracting Receipt": {
         "onload": "india_compliance.gst_india.overrides.subcontracting_transaction.onload",
         "validate": "india_compliance.gst_india.overrides.subcontracting_transaction.validate",
+        "before_submit": "india_compliance.gst_india.overrides.subcontracting_transaction.before_submit",
         "before_mapping": "india_compliance.gst_india.overrides.subcontracting_transaction.before_mapping_subcontracting_receipt",
     },
     "Supplier": {