fix: use existing utility

(cherry picked from commit 94434a4)

india_compliance/gst_india/client_scripts/purchase_invoice.js

@@ -21,8 +21,8 @@ frappe.ui.form.on(DOCTYPE, {
     onload: toggle_reverse_charge,
 
     gst_category(frm) {
-        toggle_reverse_charge(frm);
         validate_gst_hsn_code(frm);
+        toggle_reverse_charge(frm);
     },
 
     after_save(frm) {
@@ -94,8 +94,8 @@ frappe.ui.form.on(DOCTYPE, {
 
 frappe.ui.form.on("Purchase Invoice Item", {
     item_code(frm) {
-        toggle_reverse_charge(frm);
         validate_gst_hsn_code(frm);
+        toggle_reverse_charge(frm);
     },
 
     items_remove: toggle_reverse_charge,

india_compliance/gst_india/overrides/purchase_invoice.py

@@ -5,6 +5,9 @@
 from india_compliance.gst_india.overrides.sales_invoice import (
     update_dashboard_with_gst_logs,
 )
+from india_compliance.gst_india.overrides.transaction import (
+    validate_hsn_codes as _validate_hsn_codes,
+)
 from india_compliance.gst_india.overrides.transaction import validate_transaction
 from india_compliance.gst_india.utils import is_api_enabled
 from india_compliance.gst_india.utils.e_waybill import get_e_waybill_info
@@ -43,7 +46,7 @@ def validate(doc, method=None):
     if validate_transaction(doc) is False:
         return
 
-    validate_gst_hsn_code(doc)
+    validate_hsn_codes(doc)
     set_ineligibility_reason(doc)
     update_itc_totals(doc)
     validate_supplier_invoice_number(doc)
@@ -265,10 +268,12 @@ def validate_reverse_charge(doc):
     frappe.throw(_("Reverse Charge is not applicable on Import of Goods"))
 
 
-def validate_gst_hsn_code(doc):
+def validate_hsn_codes(doc):
     if doc.gst_category != "Overseas":
         return
 
-    for item in doc.items:
-        if not item.get("gst_hsn_code"):
-            frappe.throw(_("GST HSN Code is mandatory for Overseas Purchase Invoice"))
+    _validate_hsn_codes(
+        doc,
+        throw=True,
+        message="GST HSN Code is mandatory for Overseas Purchase Invoice.<br>",
+    )

india_compliance/gst_india/overrides/transaction.py

@@ -721,13 +721,13 @@ def validate_backdated_transaction(doc, gst_settings=None, action="create"):
         )
 
 
-def validate_hsn_codes(doc):
+def validate_hsn_codes(doc, throw=False, message=None):
     validate_hsn_code, valid_hsn_length = get_hsn_settings()
 
     if not validate_hsn_code:
         return
 
-    return _validate_hsn_codes(doc, valid_hsn_length, message=None)
+    return _validate_hsn_codes(doc, valid_hsn_length, throw, message)
 
 
 def validate_sales_reverse_charge(doc):
@@ -740,7 +740,7 @@ def validate_sales_reverse_charge(doc):
         )
 
 
-def _validate_hsn_codes(doc, valid_hsn_length, message=None):
+def _validate_hsn_codes(doc, valid_hsn_length, throw=False, message=None):
     rows_with_missing_hsn = []
     rows_with_invalid_hsn = []
 
@@ -773,6 +773,7 @@ def _validate_hsn_codes(doc, valid_hsn_length, message=None):
                 "{0}" "Please enter HSN/SAC code for the following row numbers: <br>{1}"
             ).format(message or "", frappe.bold(", ".join(rows_with_missing_hsn))),
             title=_("Invalid HSN/SAC"),
+            raise_exception=throw,
         )
 
     if rows_with_invalid_hsn:
@@ -787,6 +788,7 @@ def _validate_hsn_codes(doc, valid_hsn_length, message=None):
                 frappe.bold(", ".join(rows_with_invalid_hsn)),
             ),
             title=_("Invalid HSN/SAC"),
+            raise_exception=throw,
         )