Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetryConfig.DEFAULT_MAX_ATTEMPTS should be public #1180

Closed
retnuh opened this issue Sep 29, 2020 · 2 comments
Closed

RetryConfig.DEFAULT_MAX_ATTEMPTS should be public #1180

retnuh opened this issue Sep 29, 2020 · 2 comments
Labels
enhancement
Milestone
1.6.0

Comments

@retnuh
Copy link

retnuh commented Sep 29, 2020

Resilience4j version: 1.5.0

Hi there, it would be great if RetryConfig.DEFAULT_MAX_ATTEMPTS were public. This would allow services that plumb through configuration to use the library's default as it's default.
@RobWin
Copy link
Member

RobWin commented Sep 29, 2020

True. Would you like to raise a quick PR

@Romeh Romeh mentioned this issue Sep 29, 2020
Merged
@Romeh
Copy link
Member

Romeh commented Sep 29, 2020

@RobWin @retnuh PR is created #1184

@RobWin RobWin added this to the 1.6.0 milestone Sep 30, 2020
RobWin pushed a commit that referenced this issue Sep 30, 2020
@Romeh
Issue #1180: Made RetryConfig default maxAttempts public (#1184)
bec8535
@RobWin RobWin closed this as completed Sep 30, 2020
hexmind pushed a commit to hexmind/resilience4j that referenced this issue Oct 2, 2020
@Romeh @hexmind
Issue resilience4j#1180: Made RetryConfig default maxAttempts public (r…
b1ead46 
…esilience4j#1184)
hexmind pushed a commit to hexmind/resilience4j that referenced this issue Jan 19, 2023
@Romeh @hexmind
Issue resilience4j#1180: Made RetryConfig default maxAttempts public (r…
1a98a14 
…esilience4j#1184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@retnuh @RobWin @Romeh