fix: correctly load Inter font in playwright action #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skydiator
approved these changes
Jun 7, 2024
|
🎉 This PR is included in version 1.3.19 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ TICKET-000
Upstream PRs
Downstream PRs
https://github.com/reside-eng/payment-statement-components/pull/590
Changes
At some point
wgetfrom google fonts URL stopped downloading a valid Zip file so the playwright action has been failing (as seen here) - this change points to downloading the valid Inter.zip file from side-plat-tools-public bucketDebug logs were also added for easier debugging in the future
Notes for Reviewers
This has been blocking builds in payment-statement-components for many months now (seems to be since jan from looking at failed verifies, but logs don't go back that far)
Recordings/Screenshots