Skip to content

Commit

Permalink
Merge pull request #85 from reside-eng/remove_project_requirement
Browse files Browse the repository at this point in the history
fix: remove project requirement
  • Loading branch information
mathieudi authored Nov 18, 2024
2 parents 7892281 + 024c498 commit 80e6000
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
16 changes: 1 addition & 15 deletions .github/workflows/check-nodejs-dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
WORKFLOW_NAME:
required: true
type: string
ENV:
required: true
type: string
# The git ref used for checking out code
GIT_REF:
required: true
Expand Down Expand Up @@ -43,20 +40,9 @@ jobs:
timeout-minutes: ${{ inputs.TIMEOUT }}
runs-on: ubuntu-latest
env:
ENV: ${{ inputs.ENV }}
SERVICE_NAME: ${{ github.event.repository.name }}
GIT_REF: ${{ inputs.GIT_REF }}
steps:
- name: Format env for github variable
run: |
env_upper=$(echo "$ENV" | tr a-z A-Z | tr - _)
echo "ENV_UPPER=$env_upper" >> $GITHUB_ENV
- name: Set GCLOUD_PROJECT
run: |
gcloud_project=${{ vars[format('{0}_PROJECT', env.ENV_UPPER)] }}
echo "GCLOUD_PROJECT=$gcloud_project" >> $GITHUB_ENV
- name: Checkout code
uses: actions/checkout@v4

Expand Down Expand Up @@ -100,7 +86,7 @@ jobs:
- name: Authenticate with Google Cloud
uses: google-github-actions/auth@v2
with:
project_id: ${{ env.GCLOUD_PROJECT }}
project_id: reside-stage
credentials_json: ${{ secrets.DEPENDENCY_STATS_SERVICE_ACCOUNT }}

# setup-gcloud without components is required to have the proper authentication for gsutil commands
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release_library.yml
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ jobs:
uses: ./.github/workflows/check-nodejs-dependencies.yml
with:
WORKFLOW_NAME: check-dependencies
ENV: stage
GIT_REF: ''
NODE_VERSION: ${{ inputs.NODE_VERSION }}
secrets:
Expand Down

0 comments on commit 80e6000

Please sign in to comment.