Adjust to correctly work with quotes #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 5 5
Lines 95 95
=======================================
Hits 86 86
Misses 9 9Continue to review full report at Codecov.
|
scripts/run-image
Outdated
| print('\n\n============================================================================') | ||
| print('{cmd}\n\n'.format(cmd=cmd)) | ||
| print("{cmd} {kwcmd}".format(cmd=cmd, kwcmd=kwargs['cmd'] or '')) |
There was a problem hiding this comment.
can you add the \n\n at the end of the print so it's consistent with before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow the system to correctly work with quotes we need to make it so that it isn't the entire command that is wrapped with quotes, but only the portion which contains quotes. An example of this can be shown below.
This is to resolve issue #58