Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support env expansion and pre/post build scripts #17

Merged
merged 3 commits into from
Oct 8, 2018

Conversation

mikekwright
Copy link
Contributor

This PR provides the ability for dockerutils to use environment variables in both the volumes and publication_tag options in the config as well as to provide a pre and post build script capability.

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files           5        5           
  Lines          87       87           
=======================================
  Hits           82       82           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312afb1...0939cc8. Read the comment docs.

Copy link
Member

@rappdw rappdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation in README.md for run_as_root

Update documentation in README.md to show publication as well as volume supports variable replacement

@rappdw rappdw merged commit 12ed489 into master Oct 8, 2018
@rappdw rappdw deleted the feature/cfg-env-and-prepost-scripts branch October 8, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants