Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outcome printer in uncurried mode #6353

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix outcome printer in uncurried mode #6353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2731ac8
change outcome printer to adjust for uncurried the same way that the …
zth Aug 17, 2023
b75ed93
changelog
zth Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

# 11.0.0-rc.2 (Unreleased)

#### :bug: Bug Fix

- Fixed outcome printer resolution of uncurried config. https://github.com/rescript-lang/rescript-compiler/pull/6353

# 11.0.0-rc.1

#### :rocket: New Feature
Expand Down
4 changes: 1 addition & 3 deletions jscomp/syntax/src/res_outcome_printer.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,7 @@ let rec printOutTypeDoc (outType : Outcometree.out_type) =
]

and printOutArrowType ~uncurried typ =
let uncurried =
if !Config.uncurried <> Legacy then not uncurried else uncurried
in
let uncurried = Res_uncurried.getDotted ~uncurried !Config.uncurried in
let typArgs, typ = collectArrowArgs typ [] in
let args =
Doc.join
Expand Down