hover: remove spacing between type definition

[aspeddro]

Before:

Neovim LSP builtin:

VSCode:

After:

Neovim:

VSCode:

[zth]

Having a new line there is intentional for VSCode, but I do see the problem in neovim. We'll probably need to treat them differently.

[aspeddro]

Fixed by 502d591

VSCode:

Neovim:

[aspeddro]

Use MarkupContent. MarkedString and MarkedString[] are depreacted.

[zth]

That looks good. What about the dividers, would you like to test removing them completely in vim too?

[aspeddro]

Neovim automatically adds dividers between code blocks even though it doesn't return dividers \n---\n

result = {
      contents = {
        kind = "markdown",
        value = "```rescript\n(\n  Belt.Array.t<Layer.t>,\n  Layer.t => string,\n) => Belt.Array.t<string>\n```\n```rescript\ntype Belt.Array.t<'a> = array<'a>\n```\n\n```rescript\ntype Layer.t = Alface | Tomate
| Queijo | Cebola | Pao\n```\n\n\n\n  `map(xs, f)`\n\n  Returns a new array by calling `f` for each element of `xs` from the beginning to end.\n\n  ```res example\n  Belt.Array.map([1, 2], (x) => x + 1) == [3, 4]
\n  ```\n"
      }
}

[aspeddro]

Dividers do indeed improve readability.

[zth]

We should probably name supportsMarkdownLinks something smarter now that it handles more cases, but that's a question for later.

[zth]

@aspeddro ready to merge as soon as the tests are green again 👍

[aspeddro]

I don't know why the tests are failing, all the changes are committed.

[zth]

Can you resolve the merge conflict here too? I'll have a look at the tests tomorrow.

[aspeddro]

Done

[aspeddro]

🙏 Tests ✅