Port component storage to arrow-rs
#8725
Open
+558
−1,808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
58f628c to
e94a3b1
Compare
emilk
commented
Jan 17, 2025
| --- | ||
| ChunkStore { | ||
| id: test_id | ||
| config: ChunkStoreConfig { enable_changelog: true, chunk_max_bytes: 393216, chunk_max_rows: 4096, chunk_max_rows_if_unsorted: 1024 } | ||
| stats: { | ||
| num_chunks: 1 | ||
| total_size_bytes: 1.3 KiB | ||
| total_size_bytes: 1.8 KiB |
There was a problem hiding this comment.
This should be fixed when we update arrow and can run .shrink_to_fit
emilk
commented
Jan 17, 2025
| match ArrowRecordBatch::try_new_with_options( | ||
| self.schema().clone(), | ||
| row, | ||
| &arrow::array::RecordBatchOptions::new().with_row_count(Some(1)), |
There was a problem hiding this comment.
Explicitly setting row-count to one means it works even when there are no columns (e.g. due to heavy filtering)
emilk
commented
Jan 17, 2025
Comment on lines
+1236
to
+1240
| if cfg!(debug_assertions) { | ||
| panic!("Failed to create record batch: {err}"); | ||
| } else { | ||
| re_log::error_once!("Failed to create record batch: {err}"); | ||
| None |
There was a problem hiding this comment.
Better than the previous silent error
emilk
commented
Jan 17, 2025
Comment on lines
+50
to
+57
| let field = match array.data_type() { | ||
| arrow::datatypes::DataType::List(field) => field.clone(), | ||
| _ => unreachable!( | ||
| "{} should always be a list array", | ||
| self.descriptor().full_name() | ||
| ), | ||
| }; | ||
| ArrowListArray::try_new(field, offsets, array, None).map_err(|err| err.into()) |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12831826511 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12832277753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re_arrow2toarrow#3741This makes our store run 100% on arrow-rs.
arrow2 is now relegated to the margins:
re_types_builderLoggable,Archetypeetc