Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over most Rust types to use eager serialization #8703

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 15, 2025

Related

What

A sweep through all the easy-to-port types in Rust

  • passes main ci.

Left are now:

  • AnnotationContext
  • AssetVideo
  • Asset3D
  • Boxes2D
  • Boxes3D
  • Image
  • Mesh3D
  • Pinhole
  • ViewCoordinates

(copying that list into the issue)

@Wumpf Wumpf added 🦀 Rust API Rust logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
79faa49 https://rerun.io/viewer/pr/8703 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member Author

Wumpf commented Jan 16, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12804152550

@emilk emilk self-requested a review January 16, 2025 07:39
crates/viewer/re_data_ui/src/instance_path.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf added the do-not-merge Do not merge this PR label Jan 16, 2025
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jan 16, 2025
@Wumpf Wumpf merged commit 18ce378 into main Jan 17, 2025
31 checks passed
@Wumpf Wumpf deleted the andreas/more-eager-serialization-rust branch January 17, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants