Port TransportChunk to arrow-rs
#8700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
dee88f0 to
3bb1a96
Compare
3bb1a96 to
84a06f4
Compare
emilk
commented
Jan 16, 2025
| .get(Self::CHUNK_METADATA_KEY_HEAP_SIZE_BYTES) | ||
| .and_then(|s| s.parse::<u64>().ok()) | ||
| } | ||
|
|
||
| #[inline] | ||
| pub fn schema(&self) -> ArrowSchemaRef { |
There was a problem hiding this comment.
These and some other methods (num_rows, num_columns, etc) are removed because we get them for free with Deref<Target = ArrowRecordBatch>
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12804220292 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12804360957 |
teh-cmc
approved these changes
Jan 16, 2025
Comment on lines
1264
to
1266
| /// | ||
| /// Only use this if you absolutely need a [`RecordBatch`] as this adds a lot of allocation | ||
| /// overhead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re_arrow2toarrow#3741This makes
TransportChunka wrapper around an arrowRecordBatch.Future work
TransportChunkand replace it with an extension trait onRecordBatchRecordBatch(adding a schema to the rows is basically free now)