Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use full chunk table format for snapshot tests #8699

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Use full chunk table format for snapshot tests #8699

merged 1 commit into from
Jan 15, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 15, 2025

Will make it easier to switch out the TransportChunk for an RecordBatch and still have the same test output

@emilk emilk added 🔨 testing testing and benchmarks do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 15, 2025
Base automatically changed from emilk/respect-format-width to main January 15, 2025 15:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ c63de63 https://rerun.io/viewer/pr/8699 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk removed the do-not-merge Do not merge this PR label Jan 15, 2025
@emilk emilk force-pushed the emilk/full-table-format-test branch from e5b704b to c63de63 Compare January 15, 2025 15:47
@emilk emilk changed the title Respect max width of formatter when formatting ChunkStore/Chunk Use full chunk table format for snapshot tests Jan 15, 2025
@emilk emilk merged commit ac80fbc into main Jan 15, 2025
32 checks passed
@emilk emilk deleted the emilk/full-table-format-test branch January 15, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emilk