Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create re_arrow_util #8689

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Create re_arrow_util #8689

merged 10 commits into from
Jan 15, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 14, 2025

Related

Details

Adds crate re_arrow_util.

Adds two traits for downcasting arrow and arrow2 arrays in such a way that we cannot accidentally cast one into another. This will be very important for the arrow migration. It also makes the code shorter.

image

Copy link

github-actions bot commented Jan 14, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
93adae2 https://rerun.io/viewer/pr/8689 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md 🏹 arrow concerning arrow labels Jan 14, 2025
/// This is a temporary method that we use while waiting to migrate towards `arrow-rs`.
/// * `arrow2` doesn't have a `RecordBatch` type, therefore we emulate that using our `TransportChunk`s.
/// * `arrow-rs` does have one, and it natively supports concatenation.
pub fn concatenate_record_batches(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old code; moved

@emilk
Copy link
Member Author

emilk commented Jan 14, 2025

@rerun-bot full-check

@emilk emilk marked this pull request as ready for review January 14, 2025 18:18
Copy link

@emilk
Copy link
Member Author

emilk commented Jan 15, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12781699198

@teh-cmc teh-cmc merged commit efee5ad into main Jan 15, 2025
65 checks passed
@teh-cmc teh-cmc deleted the emilk/downcast-array branch January 15, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants