Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to provide local data to context menu actions #8625

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 9, 2025

Related

What

This PR adds the possibility to provide local data to context menu action from "user" code (e.g. the place where the context menu is triggered). The local data is structured as a TypeMap.

This new ability is used to fix the behaviour of Collapse/Expand all in the blueprint streams tree (which never worked before). It also unblocks the possibility to have a different collapsing start for the filtered and unfiltered states of a given tree (#8586).

@abey79 abey79 added ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
69aeca2 https://rerun.io/viewer/pr/8625 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 marked this pull request as draft January 9, 2025 13:51
@abey79
Copy link
Member Author

abey79 commented Jan 9, 2025

We have a better plan, on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant