Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RecordingStream::log implicitly requiring Sized #8587

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 6, 2025

This makes this kind of code fail to compile:

rec.log("labels", &labels as &dyn crate::AsComponents).unwrap();
rec.log("labels", &labels as &dyn crate::ComponentBatch).unwrap();

image

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🦀 Rust API Rust logging API 😤 annoying Something in the UI / SDK is annoying to use include in changelog labels Jan 6, 2025
@teh-cmc teh-cmc force-pushed the cmc/fix_sized_as_components branch from fe95f84 to 2b019bc Compare January 6, 2025 11:30
Copy link

github-actions bot commented Jan 6, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
761cc9f https://rerun.io/viewer/pr/8587 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc force-pushed the cmc/fix_sized_as_components branch from 2b019bc to 761cc9f Compare January 6, 2025 11:34
@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 6, 2025

@rerun-bot full-check

@teh-cmc teh-cmc marked this pull request as ready for review January 6, 2025 11:35
Copy link

github-actions bot commented Jan 6, 2025

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12631792769

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 6, 2025

I need this, I'm gonna assume this isn't the most controversial thingy.

@teh-cmc teh-cmc merged commit ab8bf8d into main Jan 6, 2025
64 checks passed
@teh-cmc teh-cmc deleted the cmc/fix_sized_as_components branch January 6, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant