End-to-end tagging: C++ #8316
Merged
End-to-end tagging: C++ #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
a20cd08 to
f201277
Compare
087fe42 to
74dd688
Compare
teh-cmc
commented
Dec 4, 2024
Comment on lines
+55
to
+139
| /// Unconditionally sets `archetype_name` to the given one. | ||
| ComponentDescriptor with_archetype_name(std::optional<std::string_view> archetype_name_ | ||
| ) const { | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_name = archetype_name_; | ||
| return descriptor; | ||
| } | ||
|
|
||
| /// Unconditionally sets `archetype_name` to the given one. | ||
| ComponentDescriptor with_archetype_name(const char* archetype_name_) const { | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_name = archetype_name_; | ||
| return descriptor; | ||
| } | ||
|
|
||
| /// Unconditionally sets `archetype_field_name` to the given one. | ||
| ComponentDescriptor with_archetype_field_name( | ||
| std::optional<std::string_view> archetype_field_name_ | ||
| ) const { | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_field_name = archetype_field_name_; | ||
| return descriptor; | ||
| } | ||
|
|
||
| /// Unconditionally sets `archetype_field_name` to the given one. | ||
| ComponentDescriptor with_archetype_field_name(const char* archetype_field_name_) const { | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_field_name = archetype_field_name_; | ||
| return descriptor; | ||
| } | ||
|
|
||
| /// Sets `archetype_name` to the given one iff it's not already set. | ||
| ComponentDescriptor or_with_archetype_name(std::optional<std::string_view> archetype_name_ | ||
| ) const { | ||
| if (this->archetype_field_name.has_value()) { | ||
| return *this; | ||
| } | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_name = archetype_name_; | ||
| return descriptor; | ||
| } | ||
|
|
||
| /// Sets `archetype_name` to the given one iff it's not already set. | ||
| ComponentDescriptor or_with_archetype_name(const char* archetype_name_) const { | ||
| if (this->archetype_field_name.has_value()) { | ||
| return *this; | ||
| } | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_name = archetype_name_; | ||
| return descriptor; | ||
| } | ||
|
|
||
| /// Sets `archetype_field_name` to the given one iff it's not already set. | ||
| ComponentDescriptor or_with_archetype_field_name( | ||
| std::optional<std::string_view> archetype_field_name_ | ||
| ) const { | ||
| if (this->archetype_field_name.has_value()) { | ||
| return *this; | ||
| } | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_field_name = archetype_field_name_; | ||
| return descriptor; | ||
| } | ||
|
|
||
| /// Sets `archetype_field_name` to the given one iff it's not already set. | ||
| ComponentDescriptor or_with_archetype_field_name(const char* archetype_field_name_) const { | ||
| if (this->archetype_field_name.has_value()) { | ||
| return *this; | ||
| } | ||
| ComponentDescriptor descriptor = *this; | ||
| descriptor.archetype_field_name = archetype_field_name_; | ||
| return descriptor; | ||
| } |
There was a problem hiding this comment.
Note: I tried to not repeat myself so much, but anytime I try to do something any fancier than that, either clang and/or gcc complains or things just segfault. Whatever.
a82a5bb to
82a1dae
Compare
74dd688 to
470cbd3
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12162244534 |
|
TODO: end-to-end failed on arm64 mac: |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12176032638 |
Wumpf
approved these changes
Dec 5, 2024
For now, indicators just set their component_name (same is true of all languages, so that roundtrips pass). This will change soon when we enter milestone 2: #8129 (comment), but one issue at a time. |
82a1dae to
deb1615
Compare
e9be108 to
98a76e4
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12183925403 |
90ef75b to
18cb6b3
Compare
|
oh god what now 😂 |
|
@rerun-bot full-check |
|
this is the one 👇 |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12199877275 |
d8abb0b to
772fb23
Compare
Co-authored-by: Andreas Reich <andreas@rerun.io>
7dd6190 to
87ec140
Compare
teh-cmc
added a commit
that referenced
this pull request
Dec 9, 2024
This semantically mimics very closely the way things are done in Rust, minus all technical differences due to the differences between both the languages and the SDKs. For that reason, everything stated in #8304 (comment) basically applies as-is. Pretty happy about it, I must say. * DNM: requires #8316 * Part of #7948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented with the help of @Wumpf.
This semantically mimics very closely the way things are done in Rust, minus all technical differences due to the differences between both the languages and the SDKs.
For that reason, everything stated in #8304 (comment) basically applies as-is.
Pretty happy about it, I must say.