Add map_view to the default features and improve how the nasm feature is handled and documented
#8243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
teh-cmc
approved these changes
Nov 28, 2024
teh-cmc
added a commit
that referenced
this pull request
Nov 28, 2024
…ture is handled and documented (#8243) This PR: - adds the `map_view` feature to `default` - removes everywhere the `map_view` was explicitly added that is no longer necessary - prints a warning when building in release mode with the `nasm` feature disabled (which is still the default) - document that `nasm` thing everywhere we talk about `cargo install rerun-cli` - tries to make people think before they add stuff to the `release` feature instead of the `default` feature --------- Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
map_viewcargo feature #7876What
This PR:
map_viewfeature todefaultmap_viewwas explicitly added that is no longer necessarynasmfeature disabled (which is still the default)nasmthing everywhere we talk aboutcargo install rerun-clireleasefeature instead of thedefaultfeature