Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map view to nuscenes python example #8034

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

tfoldi
Copy link
Contributor

@tfoldi tfoldi commented Nov 7, 2024

What

Small map in the nuscenes example.

👇

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@tfoldi tfoldi marked this pull request as ready for review November 7, 2024 13:24
@abey79 abey79 added examples Issues relating to the Rerun examples include in changelog feat-map-view Everything related to the map view labels Nov 7, 2024
@abey79 abey79 self-requested a review November 7, 2024 16:52
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I already committed my review comments :)

@abey79 abey79 mentioned this pull request Nov 7, 2024
27 tasks
@abey79 abey79 merged commit a23e6d9 into rerun-io:main Nov 7, 2024
32 of 33 checks passed
@tfoldi tfoldi deleted the nuscenes_mapview branch November 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples feat-map-view Everything related to the map view include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants