-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angle datatype stores now only radians #6916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6608614
to
7493b56
Compare
7493b56
to
7eedbd6
Compare
Deployed docs
|
teh-cmc
approved these changes
Jul 17, 2024
/// Angle in degrees. One turn is equal to 360 degrees. | ||
/// \py Only one of `degrees` or `radians` should be set. | ||
Degrees: rerun.datatypes.Float32 (transparent), | ||
radians: float (order: 100, "attr.cpp.prefix_field"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR but I'm surprised we didn't go for double precision here 🤔
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9972777611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
include in changelog
🪵 Log & send APIs
Affects the user-facing API for all languages
🍏 primitives
Relating to Rerun primitives
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously,
Angle
was an arrow union between radian & degree. As part of the effort of simplifying our data representations, this is now always just radians.Ran into a nameclash for C++'s
Angle
class and had to resort to a new attribute that allows renaming the field for C++ only.Simplifies the
Angle
datatype to only store radians.As far as I can tell I managed to do this in a way that should break almost no existing usage (ignoring deprecation warnings)
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.