Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable OpenGL fallback backend, fix --renderer=gl only working together with WGPU_BACKEND env-var #6582

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 17, 2024

What

Previously, we made the GL backend explicit opt-in (and accidentally only via the wgpu env var, not solely via commandline). But I don't see any reason for this as wgpu will (well, should) always prefer Vulkan when available.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself include in changelog labels Jun 17, 2024
@Wumpf Wumpf merged commit 15ce558 into main Jun 17, 2024
37 checks passed
@Wumpf Wumpf deleted the andreas/allow-gl-fallback branch June 17, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should fall back to gl on native when vulkan fails
2 participants