Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen of python scoped objects to handle mixed-scope imports #5026

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 2, 2024

What

Previously importing scopes would overlay the datatypes / components.

We now just import the scope and instead adjust the references. This allows an archetype to contain both "regular" components as well as blueprint components.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 2, 2024
@jleibs jleibs marked this pull request as ready for review February 2, 2024 19:00
@Wumpf Wumpf self-requested a review February 4, 2024 16:26
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks out, this is needed from here on

@Wumpf Wumpf merged commit 6bfd0e4 into main Feb 4, 2024
42 of 44 checks passed
@Wumpf Wumpf deleted the jleibs/mixed_scope branch February 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants