Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too easy for rerun_notebook to end up out of sync with rerun-sdk #7814

Open
jleibs opened this issue Oct 17, 2024 · 0 comments
Open

Too easy for rerun_notebook to end up out of sync with rerun-sdk #7814

jleibs opened this issue Oct 17, 2024 · 0 comments
Assignees
@jprochazk
Labels
🪳 bug Something isn't working 🐍 Python API Python logging API
Milestone
Next patch release

Comments

@jleibs
Copy link
Member

jleibs commented Oct 17, 2024

Repro:

pip install rerun-sdk[notebook]==0.18.2 
pip install rerun-sdk==0.19.0
pip freeze  | grep rerun

rerun-notebook==0.18.2
rerun-sdk==0.19.0

At a minimum we should warn, but ideally our package should express these dependencies in a way that pip yells at you first.
@jleibs jleibs added 🪳 bug Something isn't working 🐍 Python API Python logging API labels Oct 17, 2024
@jleibs jleibs added this to the Next patch release milestone Oct 17, 2024
@jprochazk jprochazk mentioned this issue Nov 7, 2024
Merged
6 tasks
jprochazk added a commit that referenced this issue Nov 12, 2024
@jprochazk
Check rerun notebook version on first import (#8030)
0ca396a 
### What

- Part of #7814

Side note: Should this close the above issue? We said we'd prefer to
express version requirements in the context of pip instead of a warning

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8030?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8030?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8030)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprochazk jprochazk

Labels
🪳 bug Something isn't working 🐍 Python API Python logging API
Projects
None yet
Milestone
Next patch release
Development

No branches or pull requests
2 participants
@jprochazk @jleibs