Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rerun-cli build on Windows #7735

Closed
emilk opened this issue Oct 15, 2024 · 0 comments · Fixed by #7750
Closed

Fix rerun-cli build on Windows #7735

emilk opened this issue Oct 15, 2024 · 0 comments · Fixed by #7750
Assignees
Labels
⛴ release Related to shipping or publishing 🪟 windows Problems specific to the Windows OS

Comments

@emilk
Copy link
Member

emilk commented Oct 15, 2024

This is blocking the release

https://github.com/rerun-io/rerun/actions/runs/11342736539/job/31543950294

rerun-cli fails to compile on Windows

@emilk emilk added 🪟 windows Problems specific to the Windows OS ⛴ release Related to shipping or publishing labels Oct 15, 2024
@emilk emilk added this to the 0.19 - Dataframe and video milestone Oct 15, 2024
@Wumpf Wumpf mentioned this issue Oct 15, 2024
6 tasks
Wumpf added a commit that referenced this issue Oct 15, 2024
### What

* Fixes #7735

Tested on @jleibs windows laptop.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7750?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7750?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7750)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛴ release Related to shipping or publishing 🪟 windows Problems specific to the Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants