-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support h.264 codec in re_video
#7375
Comments
emilk
changed the title
Support more video codecs in
Support h.264 h.265 vp8 vp9 video codecs in Sep 10, 2024
re_video
re_video
emilk
changed the title
Support h.264 h.265 vp8 vp9 video codecs in
Support h.264 codecs in Sep 16, 2024
re_video
re_video
emilk
changed the title
Support h.264 codecs in
Support h.264 codec in Sep 20, 2024
re_video
re_video
We can load h264 as of #7470, but playback is choppy. Remaining work here is to fix how we pass timestamps to the video decoder, which requires some restructuring of our buffering logic. |
6 tasks
jprochazk
added a commit
that referenced
this issue
Sep 26, 2024
### What * Closes #7375 - The seeking logic now searches for the requested segment by the presentation/composition timestamp passed in by the user. This way if a user requests frame at 12s they will get the frame which will be _presented_ at 12s, not _decoded_ at 12s. See [I/P/B frame terminology](https://en.wikipedia.org/wiki/Video_compression_picture_types) in video encoding for more information as to why this distinction matters. - `EncodedVideoChunk`s are now given the _composition timestamp_ of the sample instead of its _decode timestamp_, so the output `VideoFrame` objects are in _composition timestamp_ order. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7511?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7511?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7511) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rerun/crates/store/re_video/src/mp4.rs
Lines 31 to 42 in 07291e5
The text was updated successfully, but these errors were encountered: