Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Link to a demo.rerun.io for each PR #2167

Closed
1 task
emilk opened this issue May 17, 2023 · 3 comments
Closed
1 task

CI: Link to a demo.rerun.io for each PR #2167

emilk opened this issue May 17, 2023 · 3 comments
Assignees
@jprochazk
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less 🔨 testing testing and benchmarks

Comments

@emilk
Copy link
Member

emilk commented May 17, 2023 •
edited
Loading

We have a nice PR Build Summary for each of our PRs, but still a lot of web-related bugs slip through.

I think a good next step is to include a link to app.rerun.io (or demo.rerun.io, or test.rerun.io) directly in the PR description, with a checkbox, e.g.:

And then we mandate that this i checked before we can merge.
@emilk emilk added 🔨 testing testing and benchmarks 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less labels May 17, 2023
@emilk emilk changed the title CI: CI: Link to demo.rerun.io for each PR May 26, 2023
@emilk
Copy link
Member Author

emilk commented Jun 1, 2023 •
edited
Loading

Actually, it would probably be better to keep demo.rerun.io user-facing, and instead publish to e.g. test.rerun.io or similar.

  • demo.rerun.io: nice looking examples, probably manually published on each release
  • test.rerun.io: good test examples, that are fast to create on CI for each PR

That said, we can start with demo.rerun.io if that is faster. Anything is better than the current status quo where the viewer, and especially the web viewer, goes untested.

@emilk emilk changed the title CI: Link to demo.rerun.io for each PR CI: Link to a test.rerun.io for each PR Jun 12, 2023
@emilk emilk changed the title CI: Link to a test.rerun.io for each PR CI: Link to a demo.rerun.io for each PR Jun 27, 2023
@jprochazk jprochazk mentioned this issue Jun 28, 2023
Merged
3 tasks
emilk pushed a commit that referenced this issue Jun 28, 2023
@jprochazk
Link to demo in PR + check checkboxes (#2543)
4910617 
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Part of #2167

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested https://demo.rerun.io/pr/2543 (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2543

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/2ceab68/docs
Examples preview: https://rerun.io/preview/2ceab68/examples
<!-- pr-link-docs:end -->
@jprochazk
Copy link
Member

Should we create a new issue for part 2? (test.rerun.io)

@jprochazk jprochazk mentioned this issue Jun 29, 2023
Closed
@jprochazk
Copy link
Member

I created a separate issue, because test.rerun.io is a separate task (splitting demo.rerun.io into "fast examples to test with" and "something to show off")

emilk pushed a commit that referenced this issue Jun 29, 2023
@jprochazk @emilk
Link to demo in PR + check checkboxes (#2543)
aeb8bba 
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Part of #2167

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested https://demo.rerun.io/pr/2543 (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2543

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/2ceab68/docs
Examples preview: https://rerun.io/preview/2ceab68/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprochazk jprochazk

Labels
🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less 🔨 testing testing and benchmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilk @jprochazk