-
Notifications
You must be signed in to change notification settings - Fork 384
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tensor & depth image value ranges can now be configured (from ui & co…
…de) (#7549) ### What * Fixes #6106 * Fixes #2341 * NOT included here is image ranges, this PR is only about things affecting colormaps (#4624) Depth images (and their clouds): https://github.com/user-attachments/assets/949ffb14-38e9-452d-a84f-695104f146c8 Tensors: https://github.com/user-attachments/assets/eea3b38f-e4c7-4b97-9cc3-2fc6104ed6b7 Noteworth ripple effects & considerations in this PR: * turns out depth image constructor on Python missed a lot of parameters, fixed that * went with a new `ValueRange` component rather than reusing `Range1D` because the semantics (and names in the ui) of the later were just too unclear * we need a tagged component mechanism really badly! * decided against putting this on the tensor view as some notes indicated was the plan * ended up refactoring a few interesting things around image/tensor handling: * colormap is no longer part of `ImageInfo`, we already didn't use it for hashing it. Having now a range made it even more clear that this doesn't belong there * `finite_range` on tensor & image is now always present, using the datatypes' finite range as fallback. The `None` case handling was awkward at best and non-existant (error out) usually ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7549?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7549?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7549) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
- Loading branch information
Showing
73 changed files
with
1,175 additions
and
295 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
11 changes: 11 additions & 0 deletions
11
crates/store/re_types/definitions/rerun/components/value_range.fbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
namespace rerun.components; | ||
|
||
// --- | ||
|
||
/// Range of expected or valid values, specifying a lower and upper bound. | ||
struct ValueRange ( | ||
"attr.rust.derive": "Copy, PartialEq, bytemuck::Pod, bytemuck::Zeroable", | ||
"attr.rust.repr": "transparent" | ||
) { | ||
range: rerun.datatypes.Range1D (order: 100); | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,6 +42,7 @@ impl DepthImage { | |
meter: None, | ||
colormap: None, | ||
point_fill_ratio: None, | ||
depth_range: None, | ||
}) | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.