these are done

rerun-io · Oct 4, 2024 · b57eb71 · b57eb71
1 parent 810160f
commit b57eb71
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/crates/store/re_chunk_store/src/dataframe.rs b/crates/store/re_chunk_store/src/dataframe.rs
@@ -823,8 +823,6 @@ pub struct QueryExpression2 {
     /// Example: `ResolvedTimeRange(10, 20)`.
     pub filtered_index_range: Option<IndexRange>,
 
-    /// TODO(cmc): NOT IMPLEMENTED.
-    ///
     /// The specific index values used to filter out _rows_ from the view contents.
     ///
     /// Only rows where at least 1 column contains non-null data at these specific values will be kept
@@ -852,8 +850,6 @@ pub struct QueryExpression2 {
     // TODO(jleibs): We need an alternative name for sampled.
     pub sampled_index_values: Option<Vec<IndexValue>>,
 
-    /// TODO(cmc): NOT IMPLEMENTED.
-    ///
     /// The component column used to filter out _rows_ from the view contents.
     ///
     /// Only rows where this column contains non-null data be kept in the final dataset.

diff --git a/crates/store/re_dataframe2/src/query.rs b/crates/store/re_dataframe2/src/query.rs
@@ -27,13 +27,13 @@ use crate::{QueryEngine, RecordBatch};
 // * [x] custom selection
 // * [x] support for overlaps (slow)
 // * [x] pagination (any solution, even a slow one)
+// * [x] pov support
+// * [ ] latestat sparse-filling
+// * [ ] sampling support
 // * [ ] overlaps (less dumb)
 // * [ ] selector-based `filtered_index`
 // * [ ] clears
-// * [ ] latestat sparse-filling
 // * [ ] pagination (fast)
-// * [ ] pov support
-// * [ ] sampling support
 // * [ ] configurable cache bypass
 // * [ ] allocate null arrays once
 // * [ ] take kernel duplicates all memory