Skip to content

Commit

Permalink
Remove arrow from re_renderer
Browse files Browse the repository at this point in the history
  • Loading branch information
emilk committed Jan 17, 2025
1 parent 45d78e7 commit 464d175
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 16 deletions.
1 change: 0 additions & 1 deletion Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6308,7 +6308,6 @@ dependencies = [
"pathdiff",
"pollster 0.4.0",
"profiling",
"re_arrow2",
"re_build_tools",
"re_error",
"re_log",
Expand Down
4 changes: 0 additions & 4 deletions crates/viewer/re_renderer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ ignored = ["profiling"] # Needed to hook up wgpu, see below at dependency setup.
[features]
default = ["import-obj", "import-gltf", "import-stl"]

## Support for Arrow datatypes for end-to-end zero-copy.
arrow = ["dep:arrow2"]

## Support importing .obj files
import-obj = ["dep:tobj"]

Expand Down Expand Up @@ -83,7 +80,6 @@ wgpu.workspace = true
wgpu-core.workspace = true # Needed for error handling when wgpu-core implemented backend is used.

# optional
arrow2 = { workspace = true, optional = true }
gltf = { workspace = true, optional = true }
tinystl = { workspace = true, features = ["bytemuck"], optional = true }
serde = { workspace = true, features = ["derive"], optional = true }
Expand Down
10 changes: 0 additions & 10 deletions crates/viewer/re_renderer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,6 @@ pub mod external {

// ---------------------------------------------------------------------------

// Make Arrow integration as transparent as possible.

#[cfg(feature = "arrow")]
pub type Buffer<T> = arrow2::buffer::Buffer<T>;

#[cfg(not(feature = "arrow"))]
pub type Buffer<T> = Vec<T>;

// ---------------------------------------------------------------------------

/// Pad `RGB` to `RGBA` with the given alpha.
pub fn pad_rgb_to_rgba<T: Copy>(rgb: &[T], alpha: T) -> Vec<T> {
re_tracing::profile_function!();
Expand Down
1 change: 0 additions & 1 deletion crates/viewer/re_viewport/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ re_entity_db.workspace = true
re_log_types.workspace = true
re_log.workspace = true
re_renderer = { workspace = true, default-features = false, features = [
"arrow",
"import-gltf",
"import-obj",
"serde",
Expand Down

0 comments on commit 464d175

Please sign in to comment.