-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update how Codecov is invoked in pull requests #1734
Comments
@dcshzj does this apply to AB3 too? https://github.com/se-edu/addressbook-level3 |
Seems like it, because AB3 is using |
Thanks for checking @dcshzj . Is the deprecated one still working? If yes, when is it expected to stop working altogether? |
I could not find any authoritative information about the exact deprecation timeline. There is one pending PR to update the deprecation warning but it has not yet been merged or looked into. I am guessing that we can expect it to stop working "very soon". |
The Codecov bash uploader has been deprecated since February 2022 and may stop working at any time, causing the coverage reports used for pull requests to not be generated once that happens. In addition, the code coverage has always been specific to the Ubuntu environment, and Codecov often incorrectly report missing coverage for Windows-specific code. Let's switch to the new uploader using the codecov/codecov-action GitHub Action, and expand the coverage testing to include Mac and Windows.
We have always been using Codecov Bash uploader to perform code coverage checks for our pull requests, and to annotate on the pull request files on the specific lines that are not covered by tests. However, this practice has been deprecated since 1 February 2022.
We should update the way we invoke Codecov as part of our pull request checks, particularly in 2 aspects:
The text was updated successfully, but these errors were encountered: