Skip to content

[bun] Defer evaluation of bunVersion until after bunIsAvailable #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

blast-hardcheese
Copy link
Collaborator

Why

In attempting to support the new version of bun, we now shell out to bun before verifying its presence.

What changed

Suspend evaluation until we're past the bunIsAvailable gate.

Test plan

CI

@blast-hardcheese blast-hardcheese added the bug Something isn't working label Apr 1, 2025
@blast-hardcheese blast-hardcheese requested a review from a team as a code owner April 1, 2025 22:47
@blast-hardcheese blast-hardcheese requested review from airportyh and removed request for a team April 1, 2025 22:47
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) April 1, 2025 22:48
@blast-hardcheese blast-hardcheese merged commit 6f108dd into main Apr 1, 2025
5 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/bun-is-not-available branch April 1, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants