use usersite for getting currently installed packages #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
There's a bug in our Python module setup where removing a package using poetry will remove it from
pyproject.toml
but not.pythonlibs
. It happens because while.pythonlibs
is listed as a user site package directory and is considered a standard lib directory, it is not searched as a lib directory for gathering the list of already installed packages.There's a secondary problem: a bug in poetry where for a "GenericEnv", getting the set of paths never includes the user site package directory because the shell out command to python includes the
-I
which means isolate and implies-s : don't add user site directory to sys.path; also PYTHONNOUSERSITE
.I'd like to upstream this change in the future, but that would require a larger change (passing a config parameter to some functions and adding them to various call sites.
Changes
-I
flag for when getting paths for the generic environment