review fixes

use 'GO111MODULE=off' not 'auto' to disable remove commented out unused functions
replicatedhq · Aug 28, 2019 · c64d845 · c64d845
1 parent cc14925
commit c64d845
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 56 deletions.
diff --git a/hack/get_build_deps.sh b/hack/get_build_deps.sh
@@ -4,4 +4,4 @@ set -v
 go get github.com/golang/mock/gomock
 go install github.com/golang/mock/mockgen
 go get github.com/elazarl/go-bindata-assetfs/go-bindata-assetfs
-GO111MODULE=auto go get -u github.com/jteeuwen/go-bindata/go-bindata
+GO111MODULE=off go get -u github.com/jteeuwen/go-bindata/go-bindata
diff --git a/pkg/lifecycle/daemon/routes_navcycle_terraform.go b/pkg/lifecycle/daemon/routes_navcycle_terraform.go
@@ -18,14 +18,3 @@ func (d *NavcycleRoutes) terraformApply(c *gin.Context) {
 		"status": "confirmed",
 	})
 }
-
-// func (d *NavcycleRoutes) terraformSkip(c *gin.Context) {
-// 	debug := level.Debug(log.With(d.Logger, "method", "terraformSkip"))
-//
-// 	debug.Log("event", "deny.terraformPlan")
-// 	d.TerraformConfirmed <- false
-//
-// 	c.JSON(http.StatusOK, map[string]interface{}{
-// 		"status": "denied",
-// 	})
-// }
diff --git a/pkg/lifecycle/daemon/routes_v1.go b/pkg/lifecycle/daemon/routes_v1.go
@@ -257,22 +257,6 @@ func (d *V1Routes) getCurrentStep(c *gin.Context) {
 	c.JSON(200, result)
 }
 
-// func (d *V1Routes) terraformApply(c *gin.Context) {
-// 	debug := log.With(level.Debug(d.Logger), "handler", "terraformApply")
-// 	defer d.locker(debug)()
-// 	debug.Log("event", "terraform.apply.send")
-// 	d.TerraformConfirmed <- true
-// 	debug.Log("event", "terraform.apply.sent")
-// }
-//
-// func (d *V1Routes) terraformSkip(c *gin.Context) {
-// 	debug := log.With(level.Debug(d.Logger), "handler", "terraformSkip")
-// 	defer d.locker(debug)()
-// 	debug.Log("event", "terraform.skip.send")
-// 	d.TerraformConfirmed <- false
-// 	debug.Log("event", "terraform.skip.sent")
-// }
-
 func (d *V1Routes) postConfirmMessage(c *gin.Context) {
 	debug := level.Debug(log.With(d.Logger, "handler", "postConfirmMessage"))
 	defer d.locker(debug)()

diff --git a/pkg/lifecycle/daemon/routes_v1_kustomize.go b/pkg/lifecycle/daemon/routes_v1_kustomize.go
@@ -8,20 +8,6 @@ import (
 	"github.com/replicatedhq/ship/pkg/lifecycle/daemon/daemontypes"
 )
 
-// func (d *V1Routes) requireKustomize() gin.HandlerFunc {
-// 	return func(c *gin.Context) {
-// 		if d.currentStep == nil || d.currentStep.Kustomize == nil {
-// 			c.AbortWithError(
-// 				400,
-// 				errors.Errorf("bad request: expected phase kustomize, was %q", d.currentStepName),
-// 			)
-// 			return
-// 		}
-// 		c.Next()
-//
-// 	}
-// }
-
 func (d *V1Routes) KustomizeSavedChan() chan interface{} {
 	return d.KustomizeSaved
 }

diff --git a/pkg/lifecycle/daemon/routes_v1_unfork.go b/pkg/lifecycle/daemon/routes_v1_unfork.go
@@ -8,20 +8,6 @@ import (
 	"github.com/replicatedhq/ship/pkg/lifecycle/daemon/daemontypes"
 )
 
-// func (d *V1Routes) requireUnfork() gin.HandlerFunc {
-// 	return func(c *gin.Context) {
-// 		if d.currentStep == nil || d.currentStep.Unfork == nil {
-// 			c.AbortWithError(
-// 				400,
-// 				errors.Errorf("bad request: expected phase unfork, was %q", d.currentStepName),
-// 			)
-// 			return
-// 		}
-// 		c.Next()
-//
-// 	}
-// }
-
 func (d *V1Routes) UnforkSavedChan() chan interface{} {
 	return d.UnforkSaved
 }