-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Support --container-runtime kubelet arg removal and kustomize v5 for k8s 1.27 #4429
Conversation
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.21.4-k8s-ctrd-2023-04-26T05:00:50Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.21.3-k8s-ctrd-2023-04-26T05:00:52Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.21.2-k8s-ctrd-2023-04-26T05:00:52Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.21.0-k8s-ctrd-2023-04-26T05:01:00Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.21.1-k8s-ctrd-2023-04-26T05:01:06Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.20.1-k8s-ctrd-2023-04-26T05:01:39Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.20.0-k8s-ctrd-2023-04-26T05:01:44Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-0ddddb5-flannel-0.20.2-k8s-ctrd-2023-04-26T05:01:52Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.21.1-k8s-ctrd-2023-04-26T17:58:54Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.21.0-k8s-ctrd-2023-04-26T17:58:54Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.21.4-k8s-ctrd-2023-04-26T17:58:55Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.21.3-k8s-ctrd-2023-04-26T17:58:59Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.21.2-k8s-ctrd-2023-04-26T17:59:18Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.20.1-k8s-ctrd-2023-04-26T17:59:52Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.20.0-k8s-ctrd-2023-04-26T18:00:07Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-7b43f7d-flannel-0.20.2-k8s-ctrd-2023-04-26T18:00:07Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.21.3-k8s-ctrd-2023-04-26T18:03:40Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.21.0-k8s-ctrd-2023-04-26T18:03:41Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.21.1-k8s-ctrd-2023-04-26T18:03:47Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.21.4-k8s-ctrd-2023-04-26T18:03:46Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.21.2-k8s-ctrd-2023-04-26T18:03:51Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.20.1-k8s-ctrd-2023-04-26T18:04:38Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.20.0-k8s-ctrd-2023-04-26T18:04:38Z |
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4429-1d2ba3c-flannel-0.20.2-k8s-ctrd-2023-04-26T18:04:46Z |
There is a bug in rafael@rafael-k8s127-dev-test-20230426103405:~$ kustomize edit fix
Error: invalid Kustomization: json: cannot unmarshal string into Go struct field Kustomization.patches of type types.Patch
Usage:
kustomize edit fix [flags]
Examples:
# Fix the missing and deprecated fields in kustomization file
kustomize edit fix
Flags:
-h, --help help for fix
--vars If specified, kustomize will attempt to convert vars to replacements.
We recommend doing this in a clean git repository where the change is easy to undo.
Global Flags:
--stack-trace print a stack-trace on error In the interim I'm going to use # Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically. |
What this PR does / why we need it:
The containerd addon provides a kubeadm init and join configuration that sets the field
kubeletExtraArgs.container-runtime
. However, Kubernetes 1.27 removed this kubelet argument: https://kubernetes.io/blog/2023/03/17/upcoming-changes-in-kubernetes-v1-27/#removal-of-container-runtime-command-line-argument.Kubernetes 1.27 also introduced a new major version of kustomize, v5:
This was causing the flannel addon to fail since it was using the legacy style patches specification.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?