-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gitea): use endpoint for pr cache pagination #34022
Conversation
@zharinov i think we should create / update the http class to return an async iterator when paginate is true, so we can iterate and cancel fetching. That way we don't need another pagination just for pr cache. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So will this always rewrite, and ignore the host in the link header?
yes, same behavior as we already do in renovate/lib/util/http/gitea.ts Lines 41 to 64 in df9106f
|
i can also change it to simple pagination, like we do in |
🎉 This PR is included in version 39.160.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* upstream/main: (27 commits) chore(deps): update python:3.13 docker digest to 7be9b75 (renovatebot#34045) chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.7.7 (renovatebot#34043) docs(gitea): fix `gitUrl` support (renovatebot#34038) feat(npm): Support for new option `replacementApproach` (renovatebot#34018) chore(deps): lock file maintenance (renovatebot#33998) chore(deps): update sigstore/cosign-installer action to v3.8.0 (renovatebot#34034) docs(managers/pip-compile): update list of source files and managers (renovatebot#34030) chore(deps): update linters to v8.22.0 (renovatebot#33880) fix(gitea): use endpoint for pr cache pagination (renovatebot#34022) chore(deps): update otel/opentelemetry-collector-contrib docker tag to v0.119.0 (renovatebot#34032) feat(gradle): add support for gradle repository content descriptors (renovatebot#33692) feat(manager): add elixir as a mise core tooling (renovatebot#34025) chore(deps): update python:3.13 docker digest to d59d263 (renovatebot#34026) chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.7.6 (renovatebot#34021) fix(gitea): allow overriding platform version (renovatebot#34019) chore(deps): update dependency @types/lodash to v4.17.15 (renovatebot#34020) fix(manager/terragrunt): Update terragrunt packageName (renovatebot#33810) feat(pip-compile): support `uv pip compile` (renovatebot#33952) fix(deps): update dependency mkdocs-material to v9.6.2 (renovatebot#34010) chore(label-actions): improve logs, pr closing (renovatebot#33995) ...
Changes
Use configured endpoint in pr cache. The cache uses own pagination.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: