-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(manager/gleam): fix readme formatting #30569
docs(manager/gleam): fix readme formatting #30569
Conversation
Is this a known |
I was surprised myself, actually. Without the ignore directive, it removes 1 space char in the sub-list (leaving 3 instead of 4 spaces of indentation). It still renders as expected in whatever markdown renderer Github uses as well as my ide, but somehow mkdocs loses it in translation. |
Waiting in case @HonkingGoose has any insights |
Looking at it a bit more, it does look like prettier has a default When I add |
SummaryWe use MkDocs plus the Material for MkDocs extension to build our docs. MkDocs uses Python-Markdown, which mostly matches the Markdown spec. But Python-Markdown is different in:
The problem with setting I don't know if setting MkDocs uses Python-MarkdownQuote from MkDocs, writing with Markdown:
Differences in Python-MarkdownQuote from Python-Markdown, differences:
Material for MkDocs reference guide, listsExamples from the Material for MkDocs, reference, lists. Ordered listsSyntax:
- Nulla et rhoncus turpis. Mauris ultricies elementum leo. Duis efficitur
accumsan nibh eu mattis. Vivamus tempus velit eros, porttitor placerat nibh
lacinia sed. Aenean in finibus diam.
* Duis mollis est eget nibh volutpat, fermentum aliquet dui mollis.
* Nam vulputate tincidunt fringilla.
* Nullam dignissim ultrices urna non auctor. Ordered listsSyntax:
1. Vivamus id mi enim. Integer id turpis sapien. Ut condimentum lobortis
sagittis. Aliquam purus tellus, faucibus eget urna at, iaculis venenatis
nulla. Vivamus a pharetra leo.
1. Vivamus venenatis porttitor tortor sit amet rutrum. Pellentesque aliquet
quam enim, eu volutpat urna rutrum a. Nam vehicula nunc mauris, a
ultricies libero efficitur sed.
2. Morbi eget dapibus felis. Vivamus venenatis porttitor tortor sit amet
rutrum. Pellentesque aliquet quam enim, eu volutpat urna rutrum a.
1. Mauris dictum mi lacus
2. Ut sit amet placerat ante
3. Suspendisse ac eros arcu |
While #30608 continues to be worked on as an overall fix for this issue (and general formatting update for all markdown), would it be acceptable to merge this PR in the meantime? I can add a comment to the ignore directive and point to this issue as a reminder. There is at least one other doc where this same issue occurs (the |
🎉 This issue has been resolved in version 38.37.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm happy to merge this PR, which
Sound good, but you should link to the "proper fix PR" instead. 😉
Do you want to create a PR to apply the same "hack-job fix" to that document? |
Yes, I'll work on applying this "hack" to the conan manager, and will do my best to locate any other occurrences while we're at it. |
Changes
Correct a formatting error in the gleam manager readme, caused by prettier, which resulted in the example sub-lists rendering as parent list items.
Current Render:
Context
Fix markdown formatting and have prettier ignore the block. Tested using mkdocs locally.
Fixed Render:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: