-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/pip-compile): Change fileMatch behaviour to target pip-compile output files #26858
feat(manager/pip-compile): Change fileMatch behaviour to target pip-compile output files #26858
Conversation
Now package files are infered from command embeded in output file header. This should enable support for additional package managers that use files like setup.py, setup.cfg and those conforming to PEP 621. Command extraction from header has been moved to common module, as it will be reused in lockedDependencyUpdate and other functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding failing tests, I suppose that there is an assupmtion of default command being returned by constructPipCompileCmd
. I will look into this later.
Hi there, You are using Good luck, The Renovate team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please merge main to remove the refactor changes from this PR 🤗
I have created a migration based on all relevant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
🎉 This PR is included in version 37.187.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is a breaking change, although this manager is in its alpha stage.
I'm looking for input regarding tests. I might revert use of commander.js as command parser, as this is a bit unorthodox.
Changes
Now package files are infered from command embeded in output file header. This should enable support for additional package managers that use files like setup.py, setup.cfg and those conforming to PEP 621.
Command extraction from header has been moved to common module, as it will be reused in lockedDependencyUpdate and other functions.
Context
See discussion: #24725 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: