fix(platform/bitbucket-server): do not force lowercase project keys in autodiscover mode

[Churro]

Changes

• Removes an inconsistency on bitbucket-server where project keys in autodiscoverFilter need to be lower-cased to be found
  • Return auto-discovered repositories on bitbucket-server as-is, i.e., without always lower-casing the project key
• Make autodiscoverFilter search using minimatch case-insensitive
  • Required for existing configs with lower-cased project keys to continue auto-discovering the same repos after this PR

Context

• Allow capital letters in autodiscoverFilter #23158
  • Previous discussion probably facing the same issue: Need help with autodiscoverFilter #16111
• feat(bitbucket): Bitbucket Server platform support #2774 -> initially introduced getRepos() with r.project.key.toLowerCase() but included no reasoning why this was needed.

Notes:

• /rest/api/1.0/repos returns the project key as-is (see here or here for sample responses)
• Generally, BitBucket Server processes project key and repo slugs in REST API calls case-insensitive (this never changed)

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

Also verified by following the instructions outlined here, creating a project key with uppercase letters, adding a repository, enabling autodiscovery, and defining autodiscoverFilter with a project key that was once uppercase-only, once lower-case only.

[renovate-release]

🎉 This PR is included in version 36.5.3 🎉

The release is available on:

• GitHub release
• 36.5.3

Your semantic-release bot 📦🚀

[cascornelissen]

Just wanted to share that I'm 99% sure this change broke Renovate for us. We use Bitbucket Server where the projects have uppercase keys and our Renovate configuration used lowercase keys due to what's explained in #23158.

The diff of this PR would suggest this change is backwards compatible but until I changed our configuration to use uppercase project keys Renovate would return None of the discovered repositories matched the filter.

I'm missing tests for regex-based autodiscover filters so that could be the reason? Here's a simplified regex with the required changes.

-export RENOVATE_AUTODISCOVER_FILTER="/^project/(repo-|repo-b|.*-app)$/"
+export RENOVATE_AUTODISCOVER_FILTER="/^PROJECT/(repo-|repo-b|.*-app)$/"

[Churro]

@cascornelissen, yes, when using regular expressions, it is expectedly case-sensitive. I was thinking about programmatically appending /i to each pattern, but generally if you specify a regex without modifier, you expect it to match as-is.

[cascornelissen]

Yeah, I understand there isn't an obvious fix for it. What might be interesting is that I first tried to append /i to our configuration but that doesn't work, I assume because it's no longer detected as a regex due to it not ending with a / anymore? That might be something to look into 🤷🏼

Not putting blame on anyone, just wanted to share what we ran into and how we solved it, in case others also ran into this.

One final remark is that it confused me that our builds succeeded. I'm not sure if an error exit code makes sense if the autodiscover filter doesn't detect any repositories for example.