Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Clone objects via wrapper #22970

Merged
merged 15 commits into from
Jun 27, 2023
Merged

feat: Clone objects via wrapper #22970

merged 15 commits into from
Jun 27, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 25, 2023 •
edited
Loading

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as draft June 25, 2023 18:35
@zharinov zharinov marked this pull request as ready for review June 25, 2023 18:35
viceice
viceice reviewed Jun 25, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing when other PR is merged

@zharinov zharinov requested a review from viceice June 26, 2023 04:42
JamieMagee
JamieMagee reviewed Jun 26, 2023
View reviewed changes
rarkins
rarkins reviewed Jun 26, 2023
View reviewed changes
@zharinov
Copy link
Collaborator Author

zharinov commented Jun 26, 2023 •
edited
Loading

Seems like we can use klona library here. Last time I tried it I was concerned with circular structures, but seems like it's not the case.

rarkins
rarkins reviewed Jun 26, 2023
View reviewed changes
@Abdel-Monaam-Aouini
Copy link

what's wrong with structuredClone ?

@zharinov
Copy link
Collaborator Author

what's wrong with structuredClone ?

https://twitter.com/lukeed05/status/1616159885523312641

@zharinov
Copy link
Collaborator Author

A couple structuredClone calls remained in logger directory, but they're HTTP error handling and probably won't affect performance. We don't use clone in logger since logger is being used in clone.

@zharinov zharinov requested a review from rarkins June 26, 2023 18:04
@viceice viceice changed the title feat: Wrap structuredClone feat: wrap clone Jun 26, 2023
@viceice viceice enabled auto-merge June 26, 2023 21:17
@viceice viceice disabled auto-merge June 26, 2023 21:18
@viceice viceice changed the title feat: wrap clone feat: wrap object clone Jun 26, 2023
@zharinov zharinov changed the title feat: wrap object clone feat: Wrap object clone Jun 27, 2023
@zharinov zharinov requested a review from viceice June 27, 2023 04:55
@zharinov zharinov changed the title feat: Wrap object clone feat: Clone objects via wrapper Jun 27, 2023
@viceice viceice enabled auto-merge June 27, 2023 10:59
@rarkins rarkins requested a review from JamieMagee June 27, 2023 11:13
@viceice viceice added this pull request to the merge queue Jun 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2023
@zharinov zharinov requested a review from viceice June 27, 2023 13:07
@viceice viceice added this pull request to the merge queue Jun 27, 2023
Merged via the queue into renovatebot:main with commit 53263bb Jun 27, 2023
@viceice viceice deleted the feat/wrap-structured-clone branch June 27, 2023 13:19
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.144.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JamieMagee JamieMagee mentioned this pull request Jun 27, 2023
Merged
6 tasks
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

@Abdel-Monaam-Aouini Abdel-Monaam-Aouini Abdel-Monaam-Aouini approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zharinov @Abdel-Monaam-Aouini @renovate-release @JamieMagee @viceice @rarkins