-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): update pr baseBranch #22663
feat(github): update pr baseBranch #22663
Conversation
Reproduction: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to save the original base branch inside cache or body struct, so we can detect a manual changed PR target by users and don't overwite it.
we also need to open follow up PR's for other platforms.
Already done here: #21724
Working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The basic use case works as expected, however the logs are misleading:
DEBUG: Processing existing PR (repository=renovate-reproductions/22663, branch=renovate/node-18.x)
DEBUG: PR body changed (repository=renovate-reproductions/22663, branch=renovate/node-18.x)
"prTitle": "Update Node.js to v18.16.0"
DEBUG: updatePr(1, Update Node.js to v18.16.0, body) (repository=renovate-reproductions/22663, branch=renovate/node-18.x)
DEBUG: PR updated...prNo: 1 (repository=renovate-reproductions/22663, branch=renovate/node-18.x)
INFO: PR updated (repository=renovate-reproductions/22663, branch=renovate/node-18.x)
"pr": 1,
"prTitle": "Update Node.js to v18.16.0"
There's not a single mention of the old base branch or what's going on. Can you print an explicit message which says "PR base branch has changed" or something similar?
🎉 This PR is included in version 35.126.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
baseBranch
is changed in configContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: