Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(endoflife): Mock time #22575

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 4, 2023

Changes

One of the fixtures has date that is expired starting from today, so expected value doesn't match anymore. In order to prevent fixtures reaching their end of life, I've mocked DateTime.now().

Some refactoring was made along the way.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from rarkins and viceice June 4, 2023 14:36
@rarkins rarkins enabled auto-merge June 4, 2023 14:54
@rarkins rarkins added this pull request to the merge queue Jun 4, 2023
Merged via the queue into renovatebot:main with commit 4a9f5d9 Jun 4, 2023
@rarkins rarkins deleted the fix/endoflife-test-expired branch June 4, 2023 15:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.110.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants