Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm)!: disable rollbackPrs for npm by default #21970

Merged
merged 3 commits into from
May 5, 2023
Merged

feat(npm)!: disable rollbackPrs for npm by default #21970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e0ffb8
feat(npm)!: disable rollbackPrs for npm by default
rarkins May 4, 2023
f63a6c9
fix test
rarkins May 4, 2023
696c0e2
docs
rarkins May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/usage/configuration-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3192,9 +3192,8 @@ There are times when a dependency version in use by a project gets removed from
For some registries, existing releases or even whole packages can be removed or "yanked" at any time, while for some registries only very new or unused releases can be removed.
Renovate's "rollback" feature exists to propose a downgrade to the next-highest release if the current release is no longer found in the registry.

Renovate does not create these rollback PRs by default, with one exception: npm packages get a rollback PR if needed.

You can configure the `rollbackPrs` property globally, per-language, or per-package to override the default behavior.
Renovate does not create these rollback PRs by default, so this functionality needs to be opted-into.
We recommend you do this selectively with `packageRules` and not globally.

## ruby

Expand Down
1 change: 0 additions & 1 deletion lib/config/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ describe('config/index', () => {
const config = configParser.getManagerConfig(parentConfig, 'npm');
expect(config).toContainEntries([
['fileMatch', ['(^|/)package\\.json$']],
['rollbackPrs', true],
]);
expect(
configParser.getManagerConfig(parentConfig, 'html')
Expand Down
1 change: 0 additions & 1 deletion lib/modules/manager/npm/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export const supportsLockFileMaintenance = true;

export const defaultConfig = {
fileMatch: ['(^|/)package\\.json$'],
rollbackPrs: true,
versioning: npmVersioning.id,
digest: {
prBodyDefinitions: {
Expand Down