-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform/bitbucket): add support for Bitbucket development branching model #20860
feat(platform/bitbucket): add support for Bitbucket development branching model #20860
Conversation
…ment branch repository configurations
If memory serves correctly, there was one unresolved discussion @viceice @rarkins around should the Repository Configuration be read from
Having slept on it, I'm thinking that we keep the implementation as is and read from the "development branch" as configured by the repository's branching model configuration. In a git-flow workflow, the "development branch" feels like the right place for the configuration to be pulled from since it is the "integration" branch. The "main branch" is mainly focused on keeping a record of the production releases as they occur |
So this takes up an extra API call per repo during initialization, even if the repo doesn't have the development branching model and/or uses |
only if the new config flag is enabled |
I know, but I suspect most users will enable this and we'll probably switch to having it on by default in a future major release. It's a pity we can't get it with one API call but 2 isn't so bad. |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 35.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Continuation of #20803
Updates the Bitbucket Cloud repository initialization logic to fetch and set the development branch name instead of relying only on the main branch name.
Context
Closes #20802
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: