-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github-action): Support updating digest pinned actions #10835
Conversation
Can you also create feature issues for:
I think we need both of these in order for actions digest PRs to be more usable |
add tag follow support for pinned actions via renovate comment |
Do we support pinning digests for actions? And can it move the tag to a comment if it does? :) |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Not yet, working on it 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs changes to keep up with new feature.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
It now also supports pin digests with auto replace 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything missing?
Thought I already commented here but can't see it. Need to test the use case where tag version remains same but digest is updated. Valid tag with bogus sha in base branch should reproduce it. Also I noted that the pr body comment for pinning is wrong/outdated but it's unrelated to this PR |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Sure, creating sample pr |
@rarkins see viceice-tests/gh-action-digests#7 works 🎉 |
🎉 This PR is included in version 25.56.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Support updating github action sha pinned actions.
Sample pr's:
Context:
closes #7537
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: