Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename Error location to validationSource #10018

Merged
merged 1 commit into from
May 17, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented May 17, 2021

Changes:

Rename Error.location to Error.validationSource otherwise it collides with vfile-message type

Context:

blocks #9954

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from JamieMagee and rarkins May 17, 2021 07:23
@viceice viceice enabled auto-merge (squash) May 17, 2021 07:30
@viceice viceice merged commit 9e08eaa into main May 17, 2021
@viceice viceice deleted the refactor/error-location branch May 17, 2021 07:40
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.21.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants