Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic fork inclusion detection #20752

Closed
rarkins opened this issue Mar 4, 2023 · 2 comments · Fixed by #20759
Closed

Automatic fork inclusion detection #20752

rarkins opened this issue Mar 4, 2023 · 2 comments · Fixed by #20759
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 4, 2023

What would you like Renovate to be able to do?

Automatically run on forked repos when user intent is clear, e.g. if the user runs renovate my-account/a-fork, without requiring the user to specify includeForks: true.

If you have any ideas on how this should be implemented, please tell us here.

I think it would be easiest to replace the existing includeForks boolean option with a new option such as forkInclusion with enum values auto, enabled, disabled, defaulting to auto`.

Then for any non-autodiscover scenario, Renovate would process forks unless forkInclusion=disabled.

Is this a feature you are interested in implementing yourself?

Maybe
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump status:requirements Full requirements are not yet known, so implementation should not be started labels Mar 4, 2023
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 4, 2023

If the bot config has value auto (or unconfigured.. default) then it will be set to disabled if autodiscover is true, otherwise to disabled.

If the repo config has value auto then it will then default to the resolved bot setting from above.

rarkins added a commit that referenced this issue Mar 5, 2023
@rarkins
feat(config): automatic fork inclusion
f559060 
Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
@rarkins rarkins mentioned this issue Mar 5, 2023
Merged
6 tasks
@rarkins rarkins self-assigned this Mar 5, 2023
@rarkins rarkins added status:in-progress and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Mar 5, 2023
@rarkins rarkins linked a pull request Mar 5, 2023 that will close this issue
feat(config)!: forkProcessing #20759
Merged
6 tasks
rarkins added a commit that referenced this issue Mar 5, 2023
@rarkins
feat(config)!: forkProcessing (#20759)
9b2b69b 
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this issue Mar 8, 2023
@rarkins
feat(config)!: forkProcessing (#20759)
a832fdf 
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this issue Mar 10, 2023
@rarkins
feat(config)!: forkProcessing (#20759)
71eb40d 
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this issue Mar 10, 2023
@rarkins
feat(config)!: forkProcessing (#20759)
6373af2 
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
rarkins added a commit that referenced this issue Mar 10, 2023
@rarkins
feat(config)!: forkProcessing (#20759)
181a4d7 
Removes "includeForks" option and replaces with "forkProcessing". New default behavior is to process forks if automerge=false.

Closes #20752

BREAKING CHANGE: Forked repos will now be processed automatically if autodiscover=false. includeForks is removed and replaced by new option forkProcessing.
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 35.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config)!: forkProcessing renovatebot/renovate
2 participants
@rarkins @renovate-release