ci: use node v20 (#513)

renovatebot · Feb 12, 2024 · bb1a020 · bb1a020
1 parent d8c1313
commit bb1a020
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -20,12 +20,12 @@ concurrency:
 env:
   GIT_EMAIL: bot+pep440@renovateapp.com
   DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
-  NODE_VERSION: 18 # needs to be in sync with other v18 below
+  NODE_VERSION: 20 # needs to be in sync with other versions below
   DRY_RUN: true
 
 jobs:
   test:
-    name: ${{ matrix.node-version == 18 && format('test ({0})', matrix.os) || format('test ({0}, node-{1})', matrix.os, matrix.node-version) }}
+    name: ${{ matrix.node-version == 20 && format('test ({0})', matrix.os) || format('test ({0}, node-{1})', matrix.os, matrix.node-version) }}
     runs-on: ubuntu-latest
 
     # tests shouldn't need more time
@@ -40,7 +40,7 @@ jobs:
         #     node-version: 12
 
     env:
-      coverage: ${{ matrix.os == 'ubuntu-latest' && matrix.node-version == 18 }}
+      coverage: ${{ matrix.os == 'ubuntu-latest' && matrix.node-version == 20 }}
       NODE_VERSION: ${{ matrix.node-version }}
 
     steps:

diff --git a/jest.config.js b/jest.config.js
@@ -6,7 +6,7 @@ module.exports = {
   testEnvironment: 'node',
   collectCoverage: true,
   collectCoverageFrom: ['lib/**/*.js'],
-  coverageProvider: 'v8',
+  // coverageProvider: 'v8', bugy on node v20.11.0 :-/
   coverageReporters: ci ? ['html', 'json', 'text'] : ['html', 'text'],
   coverageThreshold: {
     global: {

diff --git a/test/specifier.test.js b/test/specifier.test.js
@@ -510,3 +510,7 @@ describe('filter([versions], specifier, {prereleases})', () => {
     });
   });
 });
+
+it('filter works without options', () => {
+  expect(filter([], '')).toEqual([]);
+});
-Original file line number
+Diff line change
@@ Expand Up @@
         });
       });
     });
+    it('filter works without options', () => {
+      expect(filter([], '')).toEqual([]);
+    });