Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make pixi-kernel work independently of kernel provisioner #18

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

renan-r-santos
Copy link
Owner

This is especially important when trying to use it in VSCode where jupyter-client isn't used to launch a kernel.

This is especially important when trying to use it in VSCode where
`jupyter-client` isn't used to launch a kernel.
@renan-r-santos renan-r-santos force-pushed the support-vscode branch 2 times, most recently from 9c0d30b to 08ab37f Compare April 17, 2024 15:15
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 22.85714% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 46.90%. Comparing base (b0e7972) to head (b87a759).

❗ Current head b87a759 differs from pull request most recent head 3d75d68. Consider uploading reports for the commit 3d75d68 to get more accurate results

Files Patch % Lines
src/pixi_kernel/__main__.py 0.00% 52 Missing ⚠️
src/pixi_kernel/pixi.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #18       +/-   ##
===========================================
- Coverage   59.75%   46.90%   -12.86%     
===========================================
  Files           3        3               
  Lines          82      113       +31     
  Branches       12       17        +5     
===========================================
+ Hits           49       53        +4     
- Misses         30       57       +27     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renan-r-santos renan-r-santos merged commit 8d98fc8 into main Apr 17, 2024
33 checks passed
@renan-r-santos renan-r-santos deleted the support-vscode branch April 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant