Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint:deno script #9540

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

alcpereira
Copy link
Contributor

Following this update from Deno Lint, JSX files are now considered by the no-unused-vars deno lint rule.

I tried a few options:

  • Adding deno.json
  • Adding a tsconfig.json (a bit redundant according to Deno docs)
  • Removing those imports

All the solutions have some pros/cons, I've personally never used deno so I don't feel 100% confident implementing the first solution (My IDE was still complaining).

Feedback from Deno users are more than welcome 🙏

I would not mind removing all those import * as React from "react"; since we're using React ^18.

Another solution would be to at least pin the Deno version in the Github Action to avoid surprises like this one.

Copy link

changeset-bot bot commented Jun 1, 2024

⚠️ No Changeset found

Latest commit: c07cd8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title ci: fix deno lint by removing react import chore: fix lint:deno script Jun 3, 2024
@MichaelDeBoey MichaelDeBoey merged commit 54e583f into remix-run:main Jun 3, 2024
5 checks passed
@alcpereira alcpereira deleted the ci/fix-deno-lint branch June 3, 2024 10:12
MichaelDeBoey pushed a commit to MichaelDeBoey/remix that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants